some general keeping up fixes

Wifx / gonetworkmanager

Go D-Bus bindings for NetworkManager

Other

96 stars 42 forks source link

some general keeping up fixes #25

Closed felixmr1 closed 2 years ago

felixmr1 commented 2 years ago

fix(examples): move examples to their own subfolders
chore(bump): update go version to 1.17 and dBus version to 5.06

mullerch commented 2 years ago

Thanks for the PR. The go version is supposed to indicate the minimal Go version to use to compile the project. This is supposed to be as permissive as possible to maximize compatibility. What is the reason of the update?

By the way, it's a good idea to make the workflow match the minimal version to ensure it's effectively the minimal requirement.

felixmr1 commented 2 years ago

Thanks for the PR. The go version is supposed to indicate the minimal Go version to use to compile the project. This is supposed to be as permissive as possible to maximize compatibility. What is the reason of the update?

By the way, it's a good idea to make the workflow match the minimal version to ensure it's effectively the minimal requirement.

Cool beans, did not know that. The reason I have for bumping is no particular other than keeping up. I guess you want to keep it as permissive as possible not to break changes for projects dependant on this one?

I can alter this PR by simply removing the latest commit. I still think the first one holds, though? Its pretty nice to be able to clone this repo and doing a go run examples/<whatever>/main.go

mullerch commented 2 years ago

I guess you want to keep it as permissive as possible not to break changes for projects dependant on this one?

Yes, it would be a shame to force users to upgrade go compile for no reason.

I still think the first one holds, though?

No big deal to me. But I see no need for retro-compatibility in this and it avoids confusion when splitting example into multiple files. So let's move on.

felixmr1 commented 2 years ago

No big deal to me. But I see no need for retro-compatibility in this and it avoids confusion when splitting example into multiple files. So let's move on.

Alright, even though I disagree. I guess you are the BDFL.