General fixes and improvements

Wifx / gonetworkmanager

Go D-Bus bindings for NetworkManager

Other

96 stars 42 forks source link

General fixes and improvements #26

Closed felixmr1 closed 2 years ago

felixmr1 commented 2 years ago

fix(SubscribeState): add the path to the recieved chan type
fix(PrimaryConnection): use ActiveConnection type
feat(AccessPoint): add LastSeen property
fix(DeviceWireless): remove duplicated fields
fix(examples): move examples to their own subfolders

felixmr1 commented 2 years ago

@mullerch I'm gathering all my changes here instead of opening separate PRs.

felixmr1 commented 2 years ago

if this PR is accepted, then I will reverse to a1ddfea

mullerch commented 2 years ago

Please check the import paths, they are not targeting the correct repository.

felixmr1 commented 2 years ago

@mullerch Yes that is due to 9dd5f1667d089a52c1f2079d93a5dc3083cb464c I was not sure if you had the time to review, so I had to move preemptively to get this to work with an internal repo. Please let me know if you request code changes, if not then I will revert to a1ddfeaa9c6eae49351ad1c767870e945db28cfd, which should be correct.

mullerch commented 2 years ago

You should do the PR on a branch, not your master so you can add only necessary changes and I can merge independently.

felixmr1 commented 2 years ago

@mullerch should be fixed now!