search

Wifx / gonetworkmanager

Go D-Bus bindings for NetworkManager
Other
99 stars 42 forks source link

Fix Device.Reapply #39

Open bminer opened 1 year ago

bminer commented 1 year ago

Device.Reapply should accept ConnectionSettings, not Connection.

Relevant doc: https://www.networkmanager.dev/docs/api/latest/gdbus-org.freedesktop.NetworkManager.Device.html#gdbus-method-org-freedesktop-NetworkManager-Device.Reapply

chrisovergaauw commented 6 months ago

@bminer I'm running into the same issue. did you find a workaround for this?

chrisovergaauw commented 6 months ago

I found a similar method in this library that works as a workaround for our project. Thought I'd drop a reference here for future readers: https://github.com/Wifx/gonetworkmanager/blob/5cd4632c13e6ea747f19c0653ec1a1040215684d/Settings.go#L83