search

Wifx / gonetworkmanager

Go D-Bus bindings for NetworkManager
Other
96 stars 42 forks source link

Still building against dbus v5.0.1 instead of 5.0.2 #5

Closed bminer closed 4 years ago

bminer commented 4 years ago

go.mod and all source files should be updated to point to dbus/v5

bminer commented 4 years ago

When I run go mod why github.com/godbus/dbus, I get this:

# github.com/godbus/dbus
mypackage.com/package
github.com/Wifx/gonetworkmanager
github.com/godbus/dbus

This is an issue because my package also depends on dbus/v5

FYI -- this is still an issue as of github.com/Wifx/gonetworkmanager@v0.1.0

bminer commented 4 years ago

From the Go documentation for modules:

exclude and replace directives only operate on the current (“main”) module. exclude and replace directives in modules other than the main module are ignored when building the main module. The replace and exclude statements, therefore, allow the main module complete control over its own build, without also being subject to complete control by dependencies. (See FAQ below for a discussion of when to use a replace directive).

https://github.com/golang/go/wiki/Modules