search

Wifx / gonetworkmanager

Go D-Bus bindings for NetworkManager
Other
96 stars 42 forks source link

[Question] Setters on properties #9

Closed joseffilzmaier closed 4 years ago

joseffilzmaier commented 4 years ago

Hello!

There are a lot of getters for almost all properties of NetworkManager. But there are almost no setters. In my case i would need the property to set a device managed or unmanaged. Is this a design decision to not include setters or simply a lack of time?

Would you take pull requests if i provide the patches in the latter case?

Greetings

mullerch commented 4 years ago

Hello, Of course new content is welcome! This library is developed by the community. Generally speaking only what is used by someone is developed. That said, I've added all the constant for the paths so that we have an overview. The first setter has just been added recently in [98840bd76a190b6d482ee8bd01ff2bf853eb1c53].

joseffilzmaier commented 4 years ago

That's nice to hear! I've created a pull request #10 - Could you please review and comment or merge?

Greetings