WiiLink24 / WiiLink24-Patcher

The repository containing patchers to help you download channels.
Mozilla Public License 2.0
145 stars 17 forks source link

WiiLink Patcher closes when typing 1 at the beginning #50

Closed ghost closed 1 year ago

ghost commented 1 year ago

I tried to use the latest release of WiiLink Patcher, but as soon as I type 1 and press enter on the main screen to do something, it closes. No matter what I do it doesn't seem to be fixed. Some desperate help would be very appreciated.

PablosCorner commented 1 year ago

You don't have to press Enter anymore (as of v.1.0.8), you can press the number and it will work.

ghost commented 1 year ago

Umm... No it doesn't. It just closes as soon as I press 1. I also checked the SD card I use but I don't see any new files added to it.

PablosCorner commented 1 year ago

I see, may I ask what OS you're using?

ghost commented 1 year ago

I'm using Windows 11.

...Please don't tell me this thing doesn't work on Windows 11... does it...?

PablosCorner commented 1 year ago

That's bizarre, I developed and tested the script on Windows 11. Could you open Windows Terminal or CMD and start the script from there, and tell me if anything strange pops up?

ghost commented 1 year ago

Okay.

I tried opening it in CMD and it says, "05 was unexpected at this time."

PablosCorner commented 1 year ago

Interesting. I can't seem to replicate the issue on my end on Windows 11, nor can I find any "05" in the batch script code. Try downloading the .bat script again and see if it still gives you the issue. If not, I'd say record a video of you trying to use the script and I can try to go from there.

ghost commented 1 year ago

Okay. I re-downloaded it and I tried to open it with Powershell. This it the result that I recoreded. https://user-images.githubusercontent.com/90027310/221977837-8f97d60b-da29-4569-979a-13c432bb7292.mp4

PablosCorner commented 1 year ago

Oh interesting, I see Korean text in the CMD, what is your locale set to?

ghost commented 1 year ago

Um... To South Korea as for now.

Was I supposed to set the locale setting to the specific one that I want to use this...?

PablosCorner commented 1 year ago

Interesting, yeah, I noticed during testing that when the locale was set to Japanese, it also broke. So, I think that's what it is. I can definitely look into it to see how I can mitigate around different locales being set. Thank you for bringing it to my attention!

ghost commented 1 year ago

Can't believe that was the issue >:(

No problem! Thank you for helping me out as well. Really appreiciate it :)

PablosCorner commented 1 year ago

I'll try out some fixes and see if I can get it to work with all locales, if so, I'll report back.

PablosCorner commented 1 year ago

Okay, after some quick tweaking, I think I got it working on the Korean (and even Japanese) locale, I'll do some more internal testing, and then release an update!

ghost commented 1 year ago

Sounds great πŸ‘ Can't wait for the release πŸ™

PablosCorner commented 1 year ago

I pushed a nightly build, if you check out the nightly branch, see if that fixes your issue.

ghost commented 1 year ago

OkayπŸ‘Œ I'll check if it works properly now.

ghost commented 1 year ago

Hmm.... Unfortunately it's still not working... :( Now this happens:

ν™”λ©΄ 캑처 2023-03-05 091540
PablosCorner commented 1 year ago

Ahhh Batch is really picky isn't it. I'll look into it more.

ghost commented 1 year ago

Gotcha πŸ‘Œ

P.S. I actually forgot to tell you that I've tried to switch my local settings to USA and that with way it works. But I'm neither living in the States nor Japan so probably the digicam and demae channel's actual features are not gonna work lol

PablosCorner commented 1 year ago

Digicam should work regardless cause you just get emailed the photos you want. For Demae, you could still use the standard version which has fake ordering.

ghost commented 1 year ago

Oh. That makes sense. I was actually kinda worried if something dumb happens since I've actually wrote my package forwarding center's address in Japan lol So you can only order actuall food in Demae channel if you're living in the States as for now right?

PablosCorner commented 1 year ago

Right now, Demae Dominos is only available in the US and Cananda. If you use the standard version, you can use it anywhere cause everything's simulated.

ghost commented 1 year ago

Ok understood πŸ‘Œ It's still mind blowing that you can actually order something with a console that's like 17 years old lol I'm actually curious how'd you guys all set it up I hope we can get more places to work with this πŸ™ Even though I don't live in the States XD

PablosCorner commented 1 year ago

I pushed another build to clear up the formatting for some of the commands, so if you want to try it again and see if it works on your end or not, I'd appreciate the feedback!

ghost commented 1 year ago

Hi. Sorry for the late reply 😞 I tried it out and... It still wasn't working... :( Now when I press 1 it just repeats the main menu over and over.

μŠ€ν¬λ¦°μƒ·_20230307_124913

I also tried copying the raw contents of the file and pasted it into a text editor and renamed it into a .bat file. Then I tried to type 1 that way, and this happened.

μŠ€ν¬λ¦°μƒ·_20230307_125545
PablosCorner commented 1 year ago

Interesting, I'll restore some of the changes I had done, but since I know it wasn't fully working before, I'll still need to figure out a solution to make it work for your setup.

ghost commented 1 year ago

Okay πŸ‘Œ Hopefully things will work out πŸ™

PablosCorner commented 1 year ago

I pushed out another nightly build, if it bugs out, please let me know!

PablosCorner commented 1 year ago

If you're interested in trying a new (potential) replacement for the Batch script, check this branch out. https://github.com/WiiLink24/WiiLink24-Patcher/tree/csharp-ver

ghost commented 1 year ago

Okay I tried both of them and the C-Sharp version was working fine(Even though I had some issues building the project with Visual Studio XD). But the nightly build was still having issues :( I can see why people becomes batch file haters lol This is what happened this time:

μŠ€ν¬λ¦°μƒ·_20230307_015403
PablosCorner commented 1 year ago

I'm glad to hear the C# version working for you at least, though there was a download link in the README for it, haha. And yeah, I learned the hard way about Batch, lmao.

EDIT: I realized I had the project set up incorrectly for the repo so it should be possible now to clone/download the repo and open it on Visual Studio and easily build/run it from there.

PablosCorner commented 1 year ago

Gonna close this as you mentioned the C# version worked fine for you.