WiiLink24 / food-server

A server designed to run the Demae channel.
MIT License
27 stars 12 forks source link

Added Functionality For Restaurant Requests (Also Functionality In Pantry) #22

Closed Skull0025 closed 1 year ago

Skull0025 commented 1 year ago

This opens a huge door for possibilities for restaurant requests!

noahpistilli commented 1 year ago

Right of the bat, some of your code will not work in production. The way you handle the response will not work because it is encoded in shift-jis.

Secondly, I noticed you just copy and pasted some of our code from room server for no apparent reason?

Third of all, we aren't looking to implement this in the way that you are doing.

toffee-makes-things commented 1 year ago

Secondly, I noticed you just copy and pasted some of our code from room server for no apparent reason?

speaking of which ???????????

Screenshot 2022-10-16 at 2 08 34 PM
toffee-makes-things commented 1 year ago

im curious did you intend for there to be any purpose with this html or was this accidental some how or like.... just what?

Skull0025 commented 1 year ago

If you look on line 22 I changed it so the user would not think adding A restaurant request was necessary. I got the code in reference from food-server. Also, What were you guys going to implement with this? Just curious.

toffee-makes-things commented 1 year ago

If you look on line 22 I changed it so the user would not think adding A restaurant request was necessary. I got the code in reference from food-server. Also, What were you guys going to implement with this? Just curious.

line 22 on what?

Skull0025 commented 1 year ago

Im Sorry, I meant line 32. Line 32 in the file in question in my fork.

toffee-makes-things commented 1 year ago

Im Sorry, I meant line 32. Line 32 in the file in question in my fork.

sorry i still dont understand the point

Skull0025 commented 1 year ago

Ok So I changed line 32 to say that because the default base_manage.html Would warn A user that Demae would break if no data was added. That is deceiving because if you don't put in a restaurant request demae will not break

Skull0025 commented 1 year ago

Also Lambda What were you guys planning to implement with Restaurant Requests Anyways?

toffee-makes-things commented 1 year ago

Also Lambda What were you guys planning to implement with Restaurant Requests Anyways?

At this time we wont, if we do it probably wont be in this way.