WiiLink24 / room-server

A backend for Wii no Ma.
MIT License
28 stars 13 forks source link

Implementations I've been thinking of, and hopeful fix of path traversal bugs? #11

Closed ghost closed 3 years ago

ghost commented 3 years ago

So firstly, I am going to be selling parts of my software on the WIi No Ma store, or pre-compiled versions for that matter. iOS jailbreaks are the main thing. Also, some of the other things I am putting on the store are My Aquarium tanks, mystery randomly generated ones. This is why my scripts pre-support these two things. Speaking of which though, the scripts have a lot of path traversal bugs, including mine. I am hoping we can fix these.

larsenv commented 3 years ago

lmfao

larsenv commented 3 years ago

By the way, who cares about My Aquarium? I had a friend who loves the game, but no one else seems to care about it. It's just an aquarium simulator. Do you like aquariums or something?

ghost commented 3 years ago

That, and we don't really have much to sell on the store, so it's nice that we at least have a little bit of things to sell. digital posters of the ones in the Wii No Ma room are another thing we will be doing. Wii is too insecure to handle payments. But yeah larsen, I just kind of need SOMETHING to sell becuase I can't sell anything pyshical?

ghost commented 3 years ago

As for liking aquariums, yeah I do. Heck, me and my Dad would have fun at Petsmart a lot in the summer looking at the fish and aquarium equipment. I'm not saying the My aquarium tanks are filler, but I don't want the shop to be useless, ya know?

larsenv commented 3 years ago

I don't understand why you're working on the shop for Wii no Ma though? I thought that Snoot and the others said we weren't bringing that back.

spotlightishere commented 3 years ago

The end goal is to provide a shop in some way - from what it seems, we can leverage their Mii Stamp assets which will be quite nice. However I am not sure how the shop, running on a Wii within Flash Player, will provide these DLC/exploits. It might be worth separating and having a unique QR that can be sold or something - another method of access.

ghost commented 3 years ago

It will actually email them Spotlight via sendgrid with the DLC/exploits, digitalcontentsender.py is the script I made for that :)

ghost commented 3 years ago

You can send any file with digitalcontentsender.py, PDF's, images, c files if you want to, zip files, anything :) Support is even there to compress files.

ghost commented 3 years ago

Not to mention I can reuse our sendgrid api key for our Mail-Go instance if needed too :D

spotlightishere commented 3 years ago

Doesn't the game require the DLC to be hosted? I don't think email will be a solution.

(Additionally, if this is true, this code should be in another repository and not integrated to room-server.)

ghost commented 3 years ago

Nah, it sends it locally from a path on the server :)

ghost commented 3 years ago

Basically, I actually figured out the DLC isn't hosted on NWCS, it's actually something you inject into your savefile. So the script generates the DLC, saves it to the same directory, and sends it off from a local file on the server :) It doesn't need to delete it as it will automatically wipe the file each time.

ghost commented 3 years ago

This has one slight flaw however. They overlap. I need to seperate and terminate each instance, in case two people want tanks at the same time.

larsenv commented 3 years ago

My Aquarium allows you to share tanks with your Wii Friends, but I don't think sending them via an actual email address will be something the Wii will parse.

ghost commented 3 years ago

Yeah I know Larsen, people will have to inject the dat file into their own savefiles. Although Larsen, similar to how you distributed a mii for the RC24 christmas present, is it possible to distribute a0014682.dat to all wii's too?

larsenv commented 3 years ago

Honestly I don't see much of a userbase for My Aquarium, it's a very niche thing.

We do Animal Crossing: City Folk DLC for instance because we believe there's a lot of people still playing it on the Wii. Even though New Horizons is on the Switch, some people don't have that and are still getting enjoyment.

ghost commented 3 years ago

Agreed yeah, I guess it's kinda because I don't know where else to put my scripts?

ghost commented 3 years ago

https://github.com/WiiLink24-Extensions/File-Maker Here is where the My Aquarium and Animal Crossing DLC WiiLink24 Extensions uses is. I slightly modified/customized some of RiiConnect24's tools to get this the way I like it :)

ghost commented 3 years ago

@larsenv So Larsen, you can implement Wii No Ma in the RC24 patcher if you want :) I do wanna however do the UNIX version myself, as I have been working on a much more improved UNIX patching engine.

spotlightishere commented 3 years ago

This issue seems off-topic, and I'm not certain as to its actual topic.