Convert remaining McFly Flux actions/stores to Redux

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system

https://dashboard.wikiedu.org

MIT License

387 stars 625 forks source link

Convert remaining McFly Flux actions/stores to Redux #1342

Closed ragesoss closed 5 years ago

ragesoss commented 7 years ago

We currently have a mix of older McFly-based Flux stores (in app/assets/javascripts/store) and a Redux store built from reducers (in app/assets/javascripts/reducers). We want to transition to using Redux for everything.

The easier ones are the Flux stores that don't use the generic StockStore as the basis. ConfirmationStore, DidYouKnowStore, UserCoursesStore, and some others are among the easier ones. CourseStore is a non-StockStore one that is fairly complex, especially because it receives so many different actions. Ultimately, with StockStore, I think we should implement each of the specific stores individually, with only the explicit actions required, rather than trying to re-implement the generic model store like StockStore does.

jyoti0208 commented 7 years ago

@ragesoss I would like to work on this.

ragesoss commented 7 years ago

@jyoti0208 cool. Once you've poked around a bit, you should note which one(s) you're working on. One at a time is probably best.

jyoti0208 commented 7 years ago

@ragesoss I have to convert all McFly-based Flux stores to the redux store?

ragesoss commented 7 years ago

@jyoti0208 that's the ultimate goal, but it can be done one store at a time.

KarmaHater commented 7 years ago

@jyoti0208 @ragesoss Could I also work on this? Maybe, I will start on DidYouKnowStore.

What I plan on doing:

Fix performance issue in feedback reducer.
Refactor all reducers to use the same style.
Break up action type file. (It is not a good idea to use one file because they get big real fast).
I will also write some tests for DidYouKnowStore reducer.

Hope to be finished by Tuesday of next week :)

KarmaHater commented 7 years ago

@jyoti0208 Here is the pull request for the DidYouKnow reducer.

https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1434

I will move onto UserCoursesStore I expect to be done by October 11, 2017 :)

jyoti0208 commented 7 years ago

@ragesoss I have started working on ConfirmationStore to move it to redux way.

KarmaHater commented 7 years ago

I just finish UserCourseStore.

@ragesoss

https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/1448

ragesoss commented 5 years ago

Done!