search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
392 stars 630 forks source link

Course navbar flashes 'missing message' briefly before rendering 'Articles' link #3849

Closed ragesoss closed 4 years ago

ragesoss commented 4 years ago

I think this bug was introduced with https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/3772

When you load a course page, it briefly shows the fallback text for a missing i18n message in the navbar instead of the appropriate Articles/Items/Pages text. This is most apparent if you do a hard refresh, for example on https://dashboard.wikiedu.org/courses/McMaster_University/Selected_Topics_in_the_Sociology_of_Education_(Winter)

This is because the wiki_string_prefix value isn't available until the course data is received from the server; the navbar renders before any course data is received, based on the initial default state of the course reducer in Redux.

The right solution here is probably to not render the navbar at all until course data is received.

TaimurAzhar commented 4 years ago

Hi, can I be assigned this issue? I am an Outreachy applicant. Looking to getting started as soon as possible. @ragesoss

ragesoss commented 4 years ago

Go for it. We don't typically assign issues, but please post again if you stop working on it.

TaimurAzhar commented 4 years ago

Great. Thanks.