search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
386 stars 600 forks source link

Improve layout of "subject specific guides" block in Timeline #5707

Closed ragesoss closed 3 months ago

ragesoss commented 4 months ago

When using the assignment wizard for a 'research and write' assignment, instructors select which subjects they will be working on, and the timeline includes a block of corresponding links to PDFs about subject-specific concerns for each of those selected subjects:

guides links

The visual layout of these links is not very elegant. They should probably float and only go to multiple lines if necessary, and they should be spaced nicely from each other.

(A PR to fix this should include a variety of 'after' screenshots with varying numbers of links.)

psankhe28 commented 4 months ago

It needs to remain on the same line and move to the next line only if the space on the current line is filled. Is this the behavior that you are looking for?

I would like to work on this.

ragesoss commented 4 months ago

@psankhe28 please work on one issue at a time.

ragesoss commented 4 months ago

It needs to remain on the same line and move to the next line only if the space on the current line is filled. Is this the behavior that you are looking for?

Yes, that sounds right.

psankhe28 commented 4 months ago

@psankhe28 please work on one issue at a time.

Yes. I'll focus on one issue at a time from now on. Thank you for the guidance

PR4NJ41 commented 4 months ago

Screenshot 2024-03-17 at 1 43 34 AM

@ragesoss is this looking good ? Please note that this change will only affect newly created courses following the merging of the pull request.

ragesoss commented 4 months ago

@psankhe28 yes, that looks good. Can it be done in a way that does work for already-created courses?

PR4NJ41 commented 4 months ago

@ragesoss I think you are referring to me. I will try but the problem is that the way it is implemented. When a course is created these blocks are created and it doesn't include a classname. If i make changes to the classname which are already present then it creates problem in other blocks since other are using the same class.

ragesoss commented 4 months ago

@PR4NJ41 yes, sorry, I meant to tag you.

Is this because the styling is being applied parent component (currently a <p>) rather than the individual a.handout-link instances? If there's no good way to do it based on just the .handout-link class, then I'm okay with it only applying to new courses.

PR4NJ41 commented 3 months ago

@ragesoss I am able to apply this based on querySelector. If it is ok should i make a PR ? I can show both the methods if you want.

ragesoss commented 3 months ago

Sure, I'd like to see both methods.

PR4NJ41 commented 3 months ago

@ragesoss I have made another PR please review it. Thank you!