WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
386 stars 600 forks source link

Improved the layout of "subject specific guides" block in Timeline. #5712

Closed PR4NJ41 closed 3 months ago

PR4NJ41 commented 3 months ago

What this PR does

Improved the layout of "subject specific guides" block in Timeline.

This is the other method which adds div with classname on block creation. This is only added to the handout section. Hence this will be added to only newly created courses.

fixes #5707

Screenshots

Before:

Before Screenshot 2024-03-21 at 1 35 51 AM Screenshot 2024-03-20 at 4 12 04 AM

After:

After Screenshot 2024-03-21 at 1 35 34 AM Screenshot 2024-03-20 at 4 12 12 AM

PR4NJ41 commented 3 months ago

@ragesoss Please review this.

PR4NJ41 commented 3 months ago

@ragesoss this might create unwanted styling changes. Also Some styling like align center of the edit menu won't work.

Before: Screenshot 2024-03-20 at 4 12 04 AM

After: Screenshot 2024-03-20 at 4 12 12 AM

ragesoss commented 3 months ago

Hmm... I actually like the bullet styling better. I don't think there is much if any custom content that uses the center formatting. I'm okay with some minor changes, as long as it doesn't break anything in a noticeable way.

PR4NJ41 commented 3 months ago

I don't think there is much if any custom content that uses the center formatting.

By center I mean the formatting as shown in the video.

https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/96368921/ad724f98-aff5-4374-8de1-b7ffc99a77ce

PR4NJ41 commented 3 months ago

@ragesoss I have made the suggested changes. Please review. Thanks!

ragesoss commented 3 months ago

By center I mean the formatting as shown in the video.

That's what I thought you meant. I think this is fine. I think you can remove the aligncenter center option by editing the tinyMCE config in text_area_input.jsx.

PR4NJ41 commented 3 months ago

@ragesoss I have made the changes.

ragesoss commented 3 months ago

Please update the screenshots to illustrate all changes (including the change to the text editor), and then this should be ready to go.

PR4NJ41 commented 3 months ago

@ragesoss I have updated the screenshots. Thanks!