WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
386 stars 600 forks source link

Feature 5693 - Training Data in Editors CSV #5723

Closed prathamVaidya closed 3 weeks ago

prathamVaidya commented 3 months ago

What this PR does

Fixes #5693

It populates the training data in the editor's CSV file.

Added three fields in the last:

image

prathamVaidya commented 3 months ago

@ragesoss I am getting "Class has too many lines" error. I am not sure how can I reduce lines in this class as nothing seems to be inheritable and no methods can be separated further.

image

ragesoss commented 3 months ago

You can add an exception for this file in .rubocop.yml, or you could find a way to extract some of the code in that file to another file. I think most of the code that doesn't have to do directly with the user and their progress (like getting the array of exercise modules vs non-exercise modules) would make sense to live in its own file, perhaps implemented via delegation in course.rb similar to how that file uses :trained_students_manager.

ragesoss commented 3 months ago

Looks like a failing test is connected to your change.

prathamVaidya commented 3 months ago

Looks like a failing test is connected to your change.

Fixed it

prathamVaidya commented 3 months ago

Finally, No errors