WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
387 stars 617 forks source link

Fix slow + flaky namespaces_stat spec #5762

Closed cyrillefr closed 5 months ago

cyrillefr commented 5 months ago

What this PR does

This PR aims to close #5660 by

Open questions and concerns

I think it might closes #5655 as well

cyrillefr commented 5 months ago

Hello @ragesoss ,

I have got this Sentry related error:

(Sentry).capture_message("Non-200 response hitting references counter API", {:extra=>{:content=>{"description"=>"mwapi error: permissiondenied - You don't have permission to vie...e_code=>"en", :project_code=>"wikipedia", :rev_id=>708326238, :status_code=>403}, :level=>"warning"})

It happens because the code in lib/reference_counter_api.rb has been commented due to commit 6f40ec12b4

I guess it is better to make the line 29 it 'logs the message if response is not 200 OK' pending and I wait and rebase :)

cyrillefr commented 5 months ago

Better now after rebase :)

ragesoss commented 5 months ago

Looks good to me!