Closed omChauhanDev closed 5 months ago
@ragesoss Sir, in which example you saw that : This new 'Show last revision' feature incorrectly shows a highlighted colour instead of the 'no attributed content' message if we load authorship data for that earlier revision and then switch back to the current revision with no remaining student work.
@om-chauhan1 it was happening in the example I linked in the issue.
@ragesoss Sir kindly see are these status correct, then i will proceed accordingly :
@ragesoss Sir kindly see are these status correct, then i will proceed accordingly :
I'm not 100% sure — I don't understand the prevHtml === nextHtml part — but it looks like you have the right idea.
One of the important bits is the handling of editors who don't have IDs that show up in the parsed authorship highlighting data... sometimes this is because of a problem with the data, even though that user actually has contributions to the current version, and sometimes it is because all their contributions were removed. You may want to explore the PR that implemented the handling of that: https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/5470
Note that 'editorsID' is an unhelpful variable name and should probably be changed, as it does not clearly communicate that these are IDs of editors who do not have highlighted content.
@ragesoss Kindly have a look : Cases :
What this PR does
Fixes #5769 This pr fixes bugs in Article Viewer.
[x] In the article viewer, if all of a student's work was removed from the article, the ArticleViewer will not keep showing the loading message
[x] Switching between the 'last' and 'current' views is only allowed when there is no pending request to the WikiWho server.
Video
After : For issue 1
After1.webm
For issue 2
After2.webm