search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
385 stars 600 forks source link

Refactor: Migrated timeline_handler.jsx from Class Based Components to Functional Components. #5828

Closed Prince0906 closed 1 week ago

Prince0906 commented 2 weeks ago

What this PR does

Converted timeline_handler from Class Based Component to Functional Component.

Screenshots

Before:

https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/145124801/b47e6681-4080-4ed6-a63b-b3645422daa6

After:

https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/145124801/f7f411d4-c2da-41ef-a4f8-cdc6f6d47efe

Open questions and concerns

This is my first time contributing to the Wiki Education Foundation. Refactoring has improved my understanding of code organization. If you find any errors or poor coding practices, please let me know and provide feedback.

Prince0906 commented 2 weeks ago

So, @ragesoss @Abishekcs i had pushed gemfile.lock also as it was said to push dependancy file so do we have to add gemfile.lock or not? Also in mac without updating the versions , the guard was asking for particular version so updated the gemfile.lock.

ragesoss commented 2 weeks ago

@Prince0906 it should only include changes to the dependency files if the PR is intended to update dependencies. In this case, there shouldn't be any changes.