search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
387 stars 617 forks source link

Converted add_admin_formComponent from class based to function based #5872

Closed shiven16 closed 2 months ago

shiven16 commented 3 months ago

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This pull request refactors the add_admin_form component from a class-based component to a functional component.

Screenshots

Before:

https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/145124527/cbfc3436-fb10-4de2-b89a-9a67d47e6fa2

After:

https://github.com/WikiEducationFoundation/WikiEduDashboard/assets/145124527/54cf5544-d3b3-4d46-bb35-58a019de8eba

Open questions and concerns

I am a beginner in open source contributions. Refactoring has improved my understanding of code organization. If you find any errors or poor coding practices, please let me know and provide feedback.

ragesoss commented 3 months ago

Please include before/after screenshots or videos demonstrating the component in action.

shiven16 commented 2 months ago

Hey @ragesoss, I have uploaded the screen recordings, could you please look at them again.

shiven16 commented 2 months ago

hey @ragesoss could you please review my PR.