search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
387 stars 617 forks source link

code migration. #5881

Open FreakForever opened 3 months ago

FreakForever commented 3 months ago

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

< describe the purpose of this pull request and note the issue it addresses > The respective pr changes the existing class component to modern react ie. to functional component using hooks.

Screenshots

Before: < add a screenshot of the UI before your change > WhatsApp July 2 Image (1)

After: < add a screenshot of the UI after your change >

Open questions and concerns

< anything you learned that you want to share, or questions you're wondering about related to this PR > WhatsApp July 3 Image

FreakForever commented 3 months ago

Hey @ragesoss, Please review my pr and let me know if any further changes are required.

FreakForever commented 2 months ago

Hey @ragesoss I have made the required changes.

ragesoss commented 2 months ago

It looks like the failing specs are related to this component.

FreakForever commented 2 months ago

Hey @ragesoss I have made the required changes.

FreakForever commented 2 months ago

Hey @ragesoss can you pls guide me, why its causing a coverage run error.

ragesoss commented 2 months ago

If you inspect the coverage logs, at the end of the Ruby test suite, you can find the details about which tests failed and why. (In this case, they are feature specs that are failing when they reach the UI for the component you changed.) I recommend running those specific tests locally to learn more. If necessary, you can modify the browser configuration in rails_helper.rb to remove the 'headless' option and watch the tests run in your browser to see exactly what is going wrong.