search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
392 stars 631 forks source link

Test for Active Course reducer #5964

Closed Formasitchijoh closed 2 months ago

Formasitchijoh commented 2 months ago

What this PR does

This PR addresses #2082 by adding comprehensive tests for the active_course reducer. I noticed a warning in the alert test and would like to handle that in a separate PR if that's okay.

Files changed

I created a new file at test/reducers/active_courses.spec.js, that contains the test

@ragesoss, @abhishekbvs , @gabina , When you have a chance, could you please review this? I'm happy to make any adjustments and ready to move on to the next reducers. or any other pressing issue,

gabina commented 2 months ago

Hi! Please don't include changes in db/schema.rb if your changes don't require migrations. Similar thing for Gemfile.lock, your changes probably do not need to update that file.

Formasitchijoh commented 2 months ago

Hi! Please don't include changes in db/schema.rb if your changes don't require migrations. Similar thing for Gemfile.lock, your changes probably do not need to update that file.

Hi, @gabina i didn't make any changes to those files, i think they were modified when i was setting up the project

gabina commented 2 months ago

Hi! Please don't include changes in db/schema.rb if your changes don't require migrations. Similar thing for Gemfile.lock, your changes probably do not need to update that file.

Hi, @gabina i didn't make any changes to those files, i think they were modified when i was setting up the project

There are three files changed in this PR: Gemfile.lock, db/schema.rb and test/reducers/active_courses.spec.js. Please add a commit reverting the changes to those files that you don't want to include in your PR.