search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
392 stars 631 forks source link

Fix: Relax the validation on term (when) field on create a course form #6017

Closed Formasitchijoh closed 2 weeks ago

Formasitchijoh commented 3 weeks ago

What this PR does

This PR addresses issue #5837 where the "Term" field in the Wiki Education Dashboard's course creation form. Previously, the validation for this field was overly strict. This update relaxes the validation criteria

Screenshots

Before:

https://github.com/user-attachments/assets/cc7c0157-3f74-4c01-9cd9-67ce361f6d4a

After:

https://github.com/user-attachments/assets/ab169d8e-8253-4aa0-af2e-d33a145ae8e8

ragesoss commented 3 weeks ago

It looks like this change would modify the validation behavior of both Programs & Events Dashboard and Wiki Education Dashboard? We still want to validate the presence of a term in wiki_education mode.

Formasitchijoh commented 3 weeks ago

@ragesoss i have checked and the term field is only available for the Wiki Education Dashboard, not in the Programs and Events Dashboard form, please clarify me if i am wrong

Formasitchijoh commented 3 weeks ago

@ragesoss i have updated this PR, sorry i miss understood the task, so I realized the field you were refering to in this case is the when field when copying a course from an external source in the P&E dashboard,

I have relaxed the validation by removing the required on the input field, i retained the slug validation to ensure if a user decided to put in a value it should be valid. and the validation of the Wiki education dashboard is maintained

please i would appreciate you feedback