search

WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
392 stars 631 forks source link

fix:issue with meeting dates extending beyond the ending date. #6028

Open shishiro26 opened 3 weeks ago

shishiro26 commented 3 weeks ago

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This pull request addresses an issue where meeting dates extend beyond the specified ending date.

Screenshots

Before: Screenshot from 2024-11-02 19-33-26

After: Screenshot from 2024-11-02 19-33-47

Open questions and concerns

I have a question regarding the timeline dates. For testing purposes, I used this course: University of Pennsylvania - Medical Missionaries to Community Partners (Fall 2023). I adjusted the start and end dates, which can be seen in the before and after screenshots.

In the current state, the start date appears to extend beyond the end date at week 10. Is this behavior intentional, or does it indicate a bug? If it is indeed an issue, should I create a new issue and work on resolving it?

651

ragesoss commented 3 weeks ago

Thanks!

It is indeed a bug that the week end dates for all of the weeks starting at week 10 are equal to the course or timeline end date, as shown in the right-hand week nav component.