WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
389 stars 628 forks source link

Trained students popover not available on mobile #67

Closed ragesoss closed 6 years ago

ragesoss commented 9 years ago

On staging, the login button is beneath the logo on mobile, rather than top left.

Also, the popovers are no longer working on mobile.

ntdb commented 9 years ago

I intentionally moved the login button below the logo on mobile to make the use of space consistent across login states. There's not enough room for the link on the top right in mobile. Ideal solution here is to use icons for menu on mobile.

Popovers have never worked on mobile due to the lack of hover state. What would an ideal replacement be? Will add tap-to-display functionality for popovers.

ntdb commented 9 years ago

Login button location is fixed in course_pages branch.

Will discuss possible solutions for displaying trained student counts on mobile with Ivan. Tap-to-display is functional but there's nothing in the designs to indicate that functionality.

ntdb commented 9 years ago
screen shot 2015-07-28 at 11 13 05 am

Desired improvements for the css-driven "popovers" (in order of current priority):

Using a library for this is totally fine, Tether might be a good place to start. It would also be cool to use React for this but we would need to "Reactify" the index page in order to use the tooltips there as well.

ragesoss commented 6 years ago

Cannot replicate anymore. Likely this was a browser implementation that now handles this automatically.