WikiEducationFoundation / WikiEduDashboard

Wiki Education Foundation's Wikipedia course dashboard system
https://dashboard.wikiedu.org
MIT License
392 stars 630 forks source link

Clicking recent activity nav links adds (rather than replaces) url components. #721

Closed ragesoss closed 8 years ago

ragesoss commented 8 years ago

Start here: https://dashboard.wikiedu.org/recent-activity

If you click back and forth several times between the different tabs of recent activity, you'll end up with a url like this: https://dashboard.wikiedu.org/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-activity/recent-edits

The functionality works, but the url won't work if loaded in a new tab/window. Probably this regression probably showed up when we upgraded to React Router 2.0. Likely easy to fix by changing the Link elements in recent_activity_handler.cjsx.

ragesoss commented 8 years ago

cc @marythought