search

WikiEducationFoundation / apps-android-wikiedudashboard

Access WikiEdu Dashboard from Android App.
https://dashboard.wikiedu.org/
MIT License
22 stars 53 forks source link

Fix: removed all hardcoded values #370

Closed Bhavnaharitsa closed 4 years ago

Bhavnaharitsa commented 4 years ago

Fixes: #84 In this pr, I have removed the hardcoded strings and also the values of the dimensions along with it.

Before The string values were hardcoded

After The string values are have replaced by the id in strings.xml and also dimens likewise.

Bhavnaharitsa commented 4 years ago

@gconnect Please review Ma'am

Bhavnaharitsa commented 4 years ago

@gconnect I have run the command "gradlew check" on my terminal. Could you please help me with spotting the exact error?

gconnect commented 4 years ago

@gconnect I have run the command "gradlew check" on my terminal. Could you please help me with spotting the exact error?

Fix this error image

Then run Run this command ./gradlew ktlintFormat

ujjwalagrawal17 commented 4 years ago

Hi @Bhavnaharitsa thanks for sending the PR ! Changes looks good to me, merging them.