search

WikiEducationFoundation / apps-android-wikiedudashboard

Access WikiEdu Dashboard from Android App.
https://dashboard.wikiedu.org/
MIT License
22 stars 53 forks source link

Migrate from MVP to MVVM architecture. #50

Open ujjwalagrawal17 opened 5 years ago

ujjwalagrawal17 commented 5 years ago

Describe the feature you'd like

Advantages of using MVVM: https://www.youtube.com/watch?v=FrteWKKVyzI&t=874s

ujjwalagrawal17 commented 5 years ago

More references:

  1. https://www.youtube.com/watch?v=FrteWKKVyzI
  2. https://www.youtube.com/watch?v=pErTyQpA390
  3. https://www.youtube.com/watch?v=Qxj2eBmXLHg
ujjwalagrawal17 commented 5 years ago

@ShridharGoel can you help us in dividing this issue into small parts. We can start with maybe 1 fragment.

ShridharGoel commented 5 years ago

@ujjwalagrawal17 Yes, sure.

victorvicari commented 4 years ago

Perhaps add one more layer, and use it for the Repository Pattern

victorvicari commented 4 years ago

And create some sort of Use Case, between the Repository and View Model, to better / cleaner deal with data / changes, if it's necessary.

victorvicari commented 4 years ago

To further improvements, remove the view / view bindings from activity / fragment classes.

gconnect commented 4 years ago

Replace the Presenters with ViewModels Replace the RetrofitProviders with Repository Remove the View binding interfaces where needed replace with data classes