search

WikiLogic / api

Providing data for the UI to consume (and possibly 3rd parties)
Apache License 2.0
1 stars 0 forks source link

Get by id returns claim with arguments. By string returns the claim alone #11

Open DouglasUT2018 opened 7 years ago

DouglasUT2018 commented 7 years ago

Should be within my limits but want to stick to one thing at a time for now so flagging for you of for me later on

DouglasUT2018 commented 7 years ago

Actually the string version is correct. Loading arguments for each premise is recursive and would require everything down to the last to be loaded or have some arbitrary stop point. So we may as well make it stop immediately. A claim will have a search menu expand from it with default to load all arguments and their premises. But this can be narrowed down to query for less.

ijmccallum commented 7 years ago

Yep - searching by string is trying to be as fast as it can be. Searching by id makes me think the args will be used so they're returned.

Adding a search for claim arguments form with filtering & sorting to a claim I think warrants it's own project in the WL github org. That's going to be a pretty big project that I reckon will span multiple repos.