Open Pokechu22 opened 1 year ago
Ah yes, that error has been annoying. Thanks!
Do we really need to pass the URL as unicode? We have the titles as unicode because we're trying to convert at the I/O boundary (so that e.g. we compare titles in unicode only), but I'm not sure requests needs it.
config[api]
is str
, so probably the URL should also be str
, good catch.
Anything holding up this being merged?
Before, files with non-ascii names would crash when using
--xmlrevisions
(a regression from #451 by @yzqzss). For example, French Wikiversity has Fichier:Ensemble_access_croisé.jpg (I'm using that as an example here because it's a small site that I know will continue to exist).Python 2's
str
vsunicode
and the implicit conversions are a mess.