WikiTransformationProject / wikitraccs-releases

Releases, issues and discussions for WikiTraccs from the Wiki Transformation Project
https://www.wikitransformationproject.com
8 stars 0 forks source link

Support for .MP4 files #51

Closed RobinAtRestore closed 1 year ago

RobinAtRestore commented 1 year ago

Hi

The trial version of WikiTraccs doesn't support the transfer of MP4 files, is this a restriction in the trial version or something that is not supported at all ?

If it's the latter (not supported) then is there a plan to add this support at all ?

Thanks

Robin

heinrich-ulbricht commented 1 year ago

@RobinAtRestore I remember migrating gigabytes of MP4 page attachments from Confluence to SharePoint, so this should work. No restriction in the trial either.

There is a list of blocked file types in SharePoint, like .jar, but this does not include MP4.

How does this look like in your case?

General:

Looking at SharePoint:

Looking at Confluence:

We'll figure this out.

RobinAtRestore commented 1 year ago

Hi,

Some more information...

Thanks

Robin

heinrich-ulbricht commented 1 year ago

Interesting! It thinks the video is an image! Will look into that. Thanks.

heinrich-ulbricht commented 1 year ago

@RobinAtRestore No this is strange.

Somehow the video is - technically - embedded as image!?

I don't know how to reproduce this. When I drag and drop an MP4 file to a Confluence page it looks like this, here one time as preview, and another time as link:

video-preview

The storage format looks like this:

<p>
    <ac:structured-macro ac:name="view-file" ac:schema-version="1"
        ac:macro-id="41cf12c9-72c9-4b7c-8dc6-ef108f8f0621">
        <ac:parameter ac:name="name">
            <ri:attachment ri:filename="test.mp4" />
        </ac:parameter>
        <ac:parameter ac:name="height">250</ac:parameter>
    </ac:structured-macro>
</p>
<p>
    <ac:link>
        <ri:attachment ri:filename="test.mp4" />
    </ac:link>
</p>

This works and looks as expected in SharePoint:

mp4embed2

Could you send me the storage format of an affected page please ( contact@wikitransformationproject.com ) - hopefully the following option is present:

image

This should make things clearer.

heinrich-ulbricht commented 1 year ago

After reviewing the storage format I can confirm that the following construct in the Confluence page causes the issue:

<ac:image ac:align="center" ac:layout="center" ac:original-height="1080" ac:original-width="1920">
   <ri:attachment ri:filename="Create a Customer Demo.mp4" ri:version-at-save="1" />
</ac:image>

This is an image element referencing a video file. WikiTraccs does not know yet that this is even possible. That's something for a next release to be handled properly. It should fall back to video migration behavior, which is: inserting a link to the video attachment into the SharePoint page.

heinrich-ulbricht commented 1 year ago

@RobinAtRestore Handling of image elements that in fact point to a video has been added in the latest release v1.3.13. Could you please try re-migrating some of the affected pages with the new version? (Delete them in SharePoint, before migrating again.)

The implementation is based on the storage format I got from you/your colleague. Let's see if it covers all affected cases - please report back. Thanks!

RobinAtRestore commented 1 year ago

Hi

i can confirm that after the latest upgrade, the file is now linked on the migrated page:

image

Thanks for your help on this.

Robin

heinrich-ulbricht commented 1 year ago

@RobinAtRestore You're welcome, thanks for the feedback.