search

WikiWatershed / mmw-micro

Micro Site Storm Model
Apache License 2.0
1 stars 0 forks source link

Initial App Import #2

Closed rajadain closed 8 years ago

rajadain commented 8 years ago

Overview

Imports micro site from Model My Watershed. Sets up basic bundling into /dist.

Notes

In an effort to minimize the difference during import, I've tried to keep the scripts consistent with what they were in Model My Watershed. However, they are now inconsistent with all our other projects which run scripts from within the VM, rather than from outside. I'm making cards to address this in the future.

We probably don't need the --vendor flag in the bundling script anymore. That is also a holdover from Model My Watershed and should be removed.

Apparently we minify only JavaScript, not any of the CSS. We should look into minifying CSS. Also, I just copied over the entire SASS directory from Model My Watershed. We can probably lose a lot of that.

Maybe we shouldn't be exporting to the /dist folder and serving from there for development? This was the easiest thing to do right now, but I feel /dist should only be used for production builds.

Even though this is going to be on a CDN, there's still a lot of files being requested. We should look into using CSS rather than Retina.js for serving higher resolution images to reduce the number of requests, and maybe also look into CSS sprites if that is not enough.

Testing Instructions

Check out this branch. Reload Vagrant so it picks up on new server port mapping. Then run the bundle script:

$ ./scripts/bundle.sh --vendor

Open localhost:8000 in a browser and test that the app works identically to the one on staging, and that there are no errors in the console.

Connects https://github.com/WikiWatershed/model-my-watershed/issues/1483

jtarricone commented 8 years ago

The app behavior looked fine, but it might be notable that npm install choked when invoked from setup.sh. I have the npm log if it would be of interest.

kdeloach commented 8 years ago

Can we change this so that running ./scripts/update.sh; ./scripts/server.sh works as expected, instead of having to run ./scripts/bundle.sh --vendor?

rajadain commented 8 years ago

Updated according to all feedback.

Starting with a fresh checkout of the repo, ./scripts/setup.sh should finish without any errors. All other scripts are expected to be run from within Vagrant.

kdeloach commented 8 years ago

+1