Unsupported major.minor version 52.0

Wikia / dropwizard-logstash-encoder

Eclipse Public License 1.0

18 stars 28 forks source link

Unsupported major.minor version 52.0 #3

Open osigida opened 9 years ago

osigida commented 9 years ago

the library is compiled with java 8 which makes it not really usable so far. better to maintain some backward compatibility, and use at least java 7

exception looks like: java.lang.UnsupportedClassVersionError: com/wikia/dropwizard/logstash/appender/LogstashSocketAppenderFactory : Unsupported major.minor version 52.0

masonbryant commented 9 years ago

Any interest in compiling with java 7?

esiqveland commented 9 years ago

Yes, please compile with at most java 7 =)

ngrigoriev commented 9 years ago

Unless your code or dependencies absolutely require Java 1.8 you should always set lower version as target. Think about your users. Not all projects are using 1.8 today. You simply make your library unusable for many projects out there.

I checked briefly - looks like the only 1.8 thing in this code is using of Map.getOrDefault() method, which is, obviously, easy to work around.