search

Wikia / sroka

Python library for API access and data analysis in Product, BI, Revenue Operations (GAM, GA, Athena etc.)
MIT License
71 stars 11 forks source link

Bump googleads floor #43

Closed MikolajBalcerek closed 3 years ago

MikolajBalcerek commented 3 years ago

googleads floor is too low - you cannot use it below 25.0.0, because all available API versions in this lib are sunsunset in the lower versions.

This floor should work till May 2022 https://webcache.googleusercontent.com/search?q=cache%3AnAu6cbUjLzQJ%3Ahttps%3A%2F%2Fdevelopers.google.com%2Fad-manager%2Fapi%2Fdeprecation%20&cd=2&hl=en&ct=clnk&gl=pl

Afterwards googleads has to be replaced with google-ads: https://ads-developers.googleblog.com/2021/04/upgrade-to-google-ads-api-from-adwords.html

martynaut commented 3 years ago

The dev version should be most up-to-date (and the PR should be done to dev branch first) and master is what was already released to pip. Does it make sense or should we change this logic? I guess there should be a note somewhere about it. If we can improve the flow somehow I'm all for it. Anyway - please make PR to dev branch + did you run any tests on the updated code? We have test file on s3. Btw should we add someone additional as code owner?

nandy-andy commented 3 years ago

Btw should we add someone additional as code owner?

I'm hoping @dorotamierzwa will lure her new teammates here and we'll have a real open-source project going on here + more people to maintenance it 🤞

MikolajBalcerek commented 3 years ago

I cannot do merges to master branch, so the request to merge dev->master and release has to be resolved between yourselves :). Consider changing/adding ownership in CODEOWNERS to "@Wikia/adeng" and make sure in the Settings tab Manage access is set to the team as well, so we won't have to use IT down the line :)

@martynaut Tested on Python 3.6.8, 3.9.4, Google Ad Manager section from Test APIs.ipnyb

Changed to target dev branch.