Wikia / sroka

Python library for API access and data analysis in Product, BI, Revenue Operations (GAM, GA, Athena etc.)
MIT License
71 stars 11 forks source link

Exception shows up without proper string formating and wrong permissions (?) #50

Open jqdq opened 2 years ago

jqdq commented 2 years ago

When the exception Configuration file {config} is not protected, make sure you're the only one allowed to read it ... is raised by line 43 in config/config.py, one instance of config is not replaced. This is because the strings are concatenated after formating, rather than before. Adding a parenthesis should help, while preserving style guidelines.

Also: Shouldn't it be chmod 700? Using chmod 600 blocks Python from entering this directory and because of that I get PermissionError. This is supported by a Stack Overflow answer.

Disclaimer: I changed the config directory to a local one in config/config.py, so this might be less of an issue when using the standard one.