search

Wikidata / SQID

A tool to analyse, browse and query Wikidata
http://tools.wmflabs.org/sqid/
Apache License 2.0
84 stars 17 forks source link

Refactor #66

Closed arsylum closed 8 years ago

arsylum commented 8 years ago

This branch introduces structural changes in the project structure. They are laid out in the file refactor.documentation

So far I've been testing it and haven't noticed any kind of leftover bugs i.e. everything is (beside introduced changes) back the way it was in terms of behavior.

To ease my mind please at least @mkroetzsch and @guenthermi take a moment to see if you run into any hidden issues or have some general concerns with the introduced changes, then it can be merged.

mkroetzsch commented 8 years ago

To minimize work, should we merge this before #59 or after? If it does not matter in terms of work, I would rather merge this one first.

arsylum commented 8 years ago

I'm not quite sure how it plays out but looking at the changes I would guess it's about the same amount of manual conflict resolution either way.

mkroetzsch commented 8 years ago

Ok, everything worked fine for me as far as I could test it. I still need to try out the compilation,but for now it is merged.