search

Wikidata / SQID

A tool to analyse, browse and query Wikidata
http://tools.wmflabs.org/sqid/
Apache License 2.0
84 stars 17 forks source link

Leftover jQuery call #81

Closed arsylum closed 8 years ago

arsylum commented 8 years ago

There is a piece of code in sqid.module (from former app/app) that apparently is used nowhere: $("[data-toggle=popover]").popover({html:true});

From what I can tell it's a jquery-ui feature, but since I cannot find markup that would be affected by it I guess it should be deleted.

Note that there also is uib-popover.

mkroetzsch commented 8 years ago

I have always been using uib-popover in my code. Maybe @guenthermi can comment.

mkroetzsch commented 8 years ago

Is this still open? Should be a small thing to fix.

arsylum commented 8 years ago

Maybe it didn't even warrant an issue. I just wanted to make sure I'm not missing something relevant. A bit of digging reveals it's actually a relic from c2246c52a53914b1a9ba1d8e9d9afc089e23109e. Not sure why it was added together with the bootstap-ui dependency, maybe it's related.

mkroetzsch commented 8 years ago

I deleted the call and pushed to master.