search

Wikidata / SQID

A tool to analyse, browse and query Wikidata
http://tools.wmflabs.org/sqid/
Apache License 2.0
84 stars 17 forks source link

SQID front page is blank on Safari 9.1.1 #99

Closed Tpt closed 8 years ago

Tpt commented 8 years ago

I get the error: SyntaxError: Unexpected token '='. Expected a ')' or a ',' after a parameter declaration. from dist.min.js line 75739.

This line is var searchEntities = function(str, lang='en', limit=7) {.

The error is raised because argument default values are not supported by other browsers than Chrome 49+ and Firefox 15+

mkroetzsch commented 8 years ago

@guenthermi If I am not mistaken, this is part of your code for the entity search. Could you please avoid this? In general, I think default parameters do not necessarily lead to good code quality, especially when used on internal (private) functions.

mkroetzsch commented 8 years ago

@Tpt The online code is also updated now. Please verify that it works correctly for you (may require shit+reload in browser to make sure you get the new code).