search

Wikidata / Wikidata-Toolkit

Java library to interact with Wikibase
https://www.mediawiki.org/wiki/Wikidata_Toolkit
Apache License 2.0
375 stars 99 forks source link

Swallowed exceptions #530

Open robertvazan opened 3 years ago

robertvazan commented 3 years ago

I notice that swallowing exceptions (catching without rethrowing or wrapping) is a widespread practice in WDTK. This can sometimes result in invalid values being propagated to application or even to API calls. Can I assume that all cases of exception swallowing are bugs and fix them?

wetneb commented 3 years ago

I think #526 is a clear improvement and I am sure there are tons of other places where we could do the same. Hard to say if it is true "everywhere", of course there is a judgment call to make…