Wikidata / soweego

Link Wikidata items to large catalogs
https://meta.wikimedia.org/wiki/Grants:Project/Hjfocs/soweego_2
GNU General Public License v3.0
97 stars 9 forks source link

Project does not fully support musical work entities #328

Closed MaxFrax closed 5 years ago

MaxFrax commented 5 years ago

In many places in the project target_database.get_person_pid is used. Tough, only mix_n_match_client.py handles that maybe the entity could be a musical work. In which case target_database.get_work_pid is called.

My proposal is to merge the two getters into a single function which, given the entity type as input, returns the right PID. This can be achieved by moving mix_n_match_client.ENTITY_TYPES etc. into target_database.py.

marfox commented 5 years ago

Done, we should now fix the usage of target_database.get_person_id in: