Closed marfox closed 3 years ago
@e-dorigatti : friendly ping
Many thanks for the review, your feedback is always super constructive and much appreciated.
return values need to be made consistent with type annotations.
Fixed.
you may look into pre-commit to automatically run type checking, linting, formatting, etc. on commit
Very interesting suggestion! We currently have a similar mechanism in place on Travis CI, see this dotfile. However, it's a bit hacky and doesn't run mypy type hints check. From a first glimpse, it looks like pre-commit is a much better solution:
This PR closes #418 . Please bear in mind that relevant refactoring suggestions from #419 are not yet addressed here: we have opened issues accordingly (#420 #421 #422) and will tackle them as soon as all the new validator features are implemented.