Wikiki / bulma-carousel

Display a carousel
MIT License
136 stars 99 forks source link

Mac CodeKit Babel transpile error #26

Closed RickCogley closed 6 years ago

RickCogley commented 6 years ago

I'm using CodeKit and am by no means a javascript expert. CodeKit lets you combine javascript into a single minified file, and also transpiles using babel. I have ESLint turned on, and it is choking on the following error:

Babel: Transpiling failed:
SyntaxError: /path/to/bulma/bower_components/bulma-carousel/dist/bulma-carousel.js: "currentActiveItem" is read-only

  104 |     if (!currentActiveItem) {
  105 |       this.items[0].classList.add('is-active');
> 106 |       currentActiveItem = this.items[0];
      |       ^
  107 |     }
  108 |     const currentActiveItemPos = this.items.indexOf(currentActiveItem);
  109 |     if (currentActiveItemPos) {

Is this an actual problem, or, should I take another course of action like, disabling ESLint? Appreciate any assistance.

Wikiki commented 6 years ago

Hi, It's an issue which have been fixed yesterday. Please update to the last version and let me know

RickCogley commented 6 years ago

Hello and thanks. I updated the module, and, it says I have 1.0.12, but, I still get the error. Also, I don't see in your master branch any change to the js file in dist anyway.

My .bower.json:

{
  "name": "bulma-carousel",
  "description": "Display a Image / Content carousel",
  "main": "carousel.sass",
  "version": "1.0.12",
  "authors": [
    "Wikiki <wikiki@protonmail.com> (https://wikiki.github.io/bulma-extensions/overview)"
  ],
  "license": "MIT",
  "keywords": [
    "Bulma",
    "extensions",
    "bulma",
    "bulma.io"
  ],
  "homepage": "https://github.com/Wikiki/bulma-carousel",
  "ignore": [
    "**/.*",
    "node_modules",
    "bower_components",
    "test",
    "tests"
  ],
  "_release": "1.0.12",
  "_resolution": {
    "type": "version",
    "tag": "1.0.12",
    "commit": "5894326339e70e27bea33cd9687f301e800319cf"
  },
  "_source": "https://github.com/Wikiki/bulma-carousel.git",
  "_target": "^1.0.12",
  "_originalSource": "bulma-carousel"
}
Wikiki commented 6 years ago

Hi,

please update to v1.1.0