Wikiki / bulma-carousel

Display a carousel
MIT License
136 stars 99 forks source link

Several errors after update to 2.0.0 #35

Closed fklement closed 6 years ago

fklement commented 6 years ago

Maybe the problem is me but:

fklement commented 6 years ago

Sorry the problem with the bulma-carousel.sass was fixed with 653d7ae2e55c8bb689c2ee9bea26ccd377da05b5.

The other two errors are still persisting with version 2.0.4.

Wikiki commented 6 years ago

Sorry. This is now working as expected

fklement commented 6 years ago

No problem at all. I installed version 2.0.6 and rebuild everything. But autoplay and navigation is still not working.

Wikiki commented 6 years ago

This is weird it's working on the demo site :-(

Wikiki commented 6 years ago

Did you call bulmaCarousel.attach() once your DOM's ready ?

fklement commented 6 years ago

Damn that was my mistake.
But now i've found some other strange behaviours:

Wikiki commented 6 years ago

Hi,

drag is under debug ;-) The white looking image was a bug into the previous version but has been fixed now. Which browser do you use ? I don't have this behavior on my side.

Wikiki commented 6 years ago

Swipe functionality has been fixed.

I'll have a look on the other issue (if I get it on my side)

Wikiki commented 6 years ago

Hi again,

can you please try again. I think it should be fixed.

fklement commented 6 years ago

Thank you very much for your efford. But the errors still persist in my application.

Wikiki commented 6 years ago

both of them ? The swipe only work with touch gesture (no mouse)

fklement commented 6 years ago

Ah ok didn't know that. But now i'm getting this error message:

main.js:9177 Uncaught ReferenceError: touchObj is not defined
    at c._swipeStart (main.js:9177)
    at HTMLDivElement.<anonymous> (main.js:9147)
_swipeStart @ main.js:9177
(anonymous) @ main.js:9147

main.js:9182 Uncaught TypeError: Cannot read property 'start' of undefined
    at c._swipeEnd (main.js:9182)
    at HTMLDivElement.<anonymous> (main.js:9151)
_swipeEnd @ main.js:9182
(anonymous) @ main.js:9151
Wikiki commented 6 years ago

Arf my last commit got into develop branch and not master....I'll update it this evening. Sorry

Wikiki commented 6 years ago

I just update the master branch and the npm package. Thanks for all your tests and feedback

Wikiki commented 6 years ago

Hi, the last update v2.0.14 should have fixed your issues (and add swipe by mouse available too)

fklement commented 6 years ago

No problem, I'll be happy to. But i'm still having the same issues with v2.0.14 like before: ezgif com-video-to-gif

main.js:9145 Unable to preventDefault inside passive event listener invocation.
_this8.previousControl.addEventListener.c.passive @ main.js:9145

main.js:9145 Unable to preventDefault inside passive event listener invocation.
_this8.previousControl.addEventListener.c.passive @ main.js:9145
Wikiki commented 6 years ago

Do you see the same blank image on the documentation site ?

regarding the preventdefault it's related to the last update and passive events. I'll fix it.

fklement commented 6 years ago

No in the docs everything is fine. Thx!

Wikiki commented 6 years ago

Weird. Maybe it's a bug with vue. Have you the possibility to share your code ?

Wikiki commented 6 years ago

Oh wait: how many images do you have in your carousel ? It could be a bug with less than 3 images....

fklement commented 6 years ago

Sure here is the html part:

    if(count($page->images)) {
        $wrapper =  "<h1 class='title is-1'>" . $page->get('headline|title') . "</h1>
                        <div class='carousel carousel-animated carousel-animate-slide mb4' data-autoplay='true' style='height: 500px;'>
                            <div class='carousel-container' style='height: 500px;'>";
        foreach($page->images as $image){
            $wrapper .= "<div class='carousel-item has-background'>
                            <img class='is-background' src='$image->url' alt='$image->description' width='640' height='310' />
                        </div>";
        }

        $wrapper .="    </div>
                        <div class='carousel-navigation is-overlay'>
                            <div class='carousel-nav-left'>
                                <i class='fa fa-chevron-left' aria-hidden='true'></i>
                            </div>
                            <div class='carousel-nav-right'>
                                <i class='fa fa-chevron-right' aria-hidden='true'></i>
                            </div>
                        </div>
                    </div>";

        echo $wrapper;
    }                   
<!-- end slider -->

You're right. When i upload more then 2 images, the problem does not appear.

Wikiki commented 6 years ago

I'll have a look at this. I don't know how to handle this case without duplicating the first item now.