search

Wikiki / bulma-divider

Bulma's extension to easily display an horizontal or vertical divider
MIT License
49 stars 57 forks source link

Please don't release breaking changes under minor version bump #10

Closed cyrilchapon closed 6 years ago

cyrilchapon commented 6 years ago

Semver is very strict regarding breaking or non breaking, but when it comes to CSS, this is less crystal clear because there is no real "API".

Changing a behavior under the same API (and talking about CSS, a single class is an API) could be seen as a breaking backward compatibility change.

Changing display from block to flex, and setting flex-grow: 1 on it is a dangerous operation, and should not, IMHO, be taken as a minor release.

When upgrading (not manually, but with default npm policy regarding Semver, ^1.0.1) from 1.0.1 to 1.0.4 It broke our layout, and apparently, we're not the only ones in that case

Yes we should be shrinkwrapping, package-locking or using yarn, but that's not a reason not to follow versioning best practises 😄

Wikiki commented 6 years ago

My bad. Sorry for the inconvenience. I'll be more carefull to it next time.

Wikiki commented 6 years ago

Except for the versioning which will be take into account better next time. Can you please confirm everything's now fine with the version 1.0.5 ?

cyrilchapon commented 6 years ago

I don't have a clue, I spent the whole morning reverting that xD

I'll be trying next week