Documentation with broken JS

Wikiki / bulma-slider

Bulma's extension to display sliders

MIT License

48 stars 35 forks source link

Documentation with broken JS #5

Closed michaelwitk closed 7 years ago

michaelwitk commented 7 years ago

https://wikiki.github.io/bulma-extensions/slider#sliderJsExample

See PR https://github.com/Wikiki/bulma-slider/pull/4

Wikiki commented 7 years ago

Sorry, I revert your PR because the initial code was good. It's slider input which have has-output class. So the test is on the right variable (slider and not output)

Regards

michaelwitk commented 7 years ago

It is indeed good, I did also only spot it after you accepted my PR. But the docs do not provide working JS code.

ewl6nwi

Wikiki commented 7 years ago

You're right, thanks