search

Wikiki / bulma-slider

Bulma's extension to display sliders
MIT License
48 stars 35 forks source link

Version 2.0.5 of this package breaks bulma SASS builds #69

Open remcohaszing opened 2 years ago

remcohaszing commented 2 years ago

The following line breaks various bulma styles when bulma and bulma-checkradio are built using SASS

https://github.com/Wikiki/bulma-slider/blob/ba0c40679d0427b84e221d853112a717b8bc691a/src/sass/index.sass#L2

This import changes the CSS order, causing the build output CSS to prefer certain styles over others, because the selectors have the same CSS specificity.

I.e. this line causes Bulma buttons to not have borders and button text to be aligned left, instead of centered.

This is the same essentially the same issue as Wikiki/bulma-checkradio#69

The workaround is to use version 2.0.4.

Gibbo3771 commented 2 years ago

For me it's not even building, sass will straight up just die.

css_1       | Error: Can't find stylesheet to import.
css_1       |   ╷
css_1       | 2 │ @import "node_modules/bulma/sass/utilities/_all.sass"
css_1       |   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
css_1       |   ╵
css_1       |   bulma-slider/src/index.sass 2:9         @import
css_1       |   app/assets/stylesheets/bulma.scss 40:9  root stylesheet

Changing to 2.0.4 fixes it.