search

Wikiki / bulma-steps

Bulma's extension to manage steps
MIT License
96 stars 44 forks source link

onFinish never called #17

Closed wolfsblu closed 6 years ago

wolfsblu commented 6 years ago

Correct me if I'm wrong, but as far as I understand it onFinish will never get called. If you consider this line in index.js it compares the next_id with the number of steps and only triggers onFinish when the next_id is equal to the step count.

I thought onFinish would be called when you are on the second to last step and proceed to the last step. The problem is, since next_id is zero-based and the step length is not, when you're at the (n - 1)st step this line will never evaluate to true, since you're comparing against n.

yacinelazaar commented 5 years ago

Just a reminder that this fix didn't make it to 2.2.1.

rahadi commented 3 years ago

@yacinelazaar do you know which version has this change? I couldn't find it.