search

Wikiki / bulma-steps

Bulma's extension to manage steps
MIT License
96 stars 44 forks source link

Copied code from my steps extension #4

Closed aramvisser closed 7 years ago

aramvisser commented 7 years ago

Hi @wikiki,

There are some issues with your steps extension code. I noticed that you changed the look for your steps extension since I made my extension. It now more closely resembles mine.

I can also clearly tell you directly copied some code from me. Your steps-size sass mixin is very similar with the exact same comment above it.

Your steps examples in the documentation are also taken directly from me (you only use 4 steps, but your final step still says step 5).

You also added very similar css classes that I used, like step-marker and step-content.

Can you either rewrite all those parts to be your own or give me credit to say where you got it from?

Wikiki commented 7 years ago

Hi @aramvisser,

You're right, I took your example text for my documentation -> It as been changed now.

I also renamed my selector from 'tag' to 'marker' because I found your choose for the name is more relevant that my old one: I'll give you credit for that.

I also took your mixin declaration you're right but not the idea and not the way to implement it (only the declaration).

I've added a credit to you on my documentation page and in the README.

Kindly regards,

aramvisser commented 7 years ago

Thanks for the credit.

Good luck with the rest of your extensions and the documentation!