search

Wikimedia-AU / MediaWiki-skin

This repo has moved to Gerrit.
https://gerrit.wikimedia.org/r/q/project:mediawiki/skins/WMAU
2 stars 1 forks source link

Consider using SkinMustache #15

Closed jdlrobson closed 3 years ago

jdlrobson commented 3 years ago

I saw you are working on this during inspiration week. I'm curious if you've taken a look at SkinMustache as a simpler way to build your skin. I'd be super interested in supporting you using it and uncovering bugs/problems as I've been trying to move us away from BaseTemplate in our codebases :).

Lemme know!

samwilson commented 3 years ago

I must admit I've been only vaguely aware of SkinMustache, sorry! I looked at it a while ago and got discouraged that it wasn't Twig. :-P

I'll have a dig and see about switching this skin to it. Doesn't sound like it'd be too hard. I assume I'd subclass SkinMustache in order to add my own functions etc.? The Example skin doesn't have anything like that. For example, this weird title-building thing (I'm so over having everything smashed up against the namespace colon).

jdlrobson commented 3 years ago

I could submit a few patches to get you started. I think you will like the data/template separation even if it's not Twig :)

samwilson commented 3 years ago

I've had a pretty crap go at it in #16. There's a bunch of stuff I'm not sure about, and am hacking lots. But I'm learning! :-)

Is this talk page the best place to ask questions of you?

jdlrobson commented 3 years ago

Yeh! Or here! I'll happily use this as an excuse to improve the docs!

jdlrobson commented 3 years ago

Looks like this can be closed now :)