Closed pixelhaufen closed 3 years ago
reiterbene
commented
4 years ago Is this a complete list or are there a lot more wrong GKZs? As the mapping file from Mapbox-IDs to GKZs is locally included in the Web-App I can fix the incorrect numbers directly on the client side.
pixelhaufen
commented
4 years ago No, that's just what I found clicking around on the map... I can offer you a list of all GKZs from wp. Gemeinde_Wikidata_Kennzahl.csv.zip Can you compare this with the list in the app to find different entries?
reiterbene
commented
4 years ago @BraveheartWikimedia The mapping can be found in this file: https://github.com/Wikimedia-Austria/WikiDaheim/blob/master/src/config/boundaries.json If requested I can have a look into this.
pixelhaufen
commented
4 years ago Here is a diff for the data:
| Gemeinde | GKZ | GKZ |
|---|---|---|
| Sankt Veit in der Südsteiermark | 61060 | 61056 |
| Straß in Steiermark | 61061 | 61058 |
| Peuerbach | 40835 | 40819 |
| Helfenberg | 41345 | 41310 |
| St. Stefan-Afiesl | 41346 | - |
| Schwanberg (Steiermark) | 60349 | - |
| Bruck-Waasen | - | 40803 |
| Schönegg | - | 41340 |
BraveheartWikimedia
commented
4 years ago @reiterbene Yes please - I assume the boundaries file needs to be changed to reflect the actual municipality keys?
reiterbene
commented
3 years ago @BraveheartWikimedia in the branch gkz-fixes I have integrated an interactive mapping editor. Just checkout the branch and run yarn check:boundaries in the terminal. After running through the wizard a new mapping file will be generated which you can push into the branch.
BraveheartWikimedia
commented
3 years ago @reiterbene Thanks (and sorry for the late reply)! Is this boundary-check still necessary or did you fix that back in September?
BR, Philip
reiterbene
commented
3 years ago Hey@BraveheartWikimedia,
yes, I am still waiting for you to run the boundary checker.
BraveheartWikimedia
commented
3 years ago Ok, will do this tonight!
BraveheartWikimedia
commented
3 years ago @reiterbene I've updated the boundary file and uploaded it as boundaries_mapped.json to the branch. Two municipalities don't have an ID anymore because they don't exist anymore (Bruck-Waasen and Schönegg), the rest should be ok. Not sure why Vienna needed to be remapped, hope I didn't mess something up.
The backend can't deal with the random/fantasy Gemeindekennzahl if somebody clicks on the map.
It would be possible to map those to the correct ones, however somebody would have to create a list of all fantasy numbers and the correct ones.
However there is no way to fix 'Breitenfurt bei Wien' (Q662190 vs. Q693181) since it's the correct one of 'Laab im Walde'