Wikimedia-Austria / WikiDaheim

The front-end of WikiDaheim
https://wikidaheim.at
7 stars 4 forks source link

missing entries from Denkmalliste #183

Closed HerziPinki closed 3 weeks ago

HerziPinki commented 1 month ago

See https://wikidaheim.at/Q665243 (Reichenau an der Rax)

the Huthaus (https://de.wikipedia.org/wiki/Liste_der_denkmalgesch%C3%BCtzten_Objekte_in_Reichenau_an_der_Rax#Q37956822) is not shown in the list, if filtering is done by just only Denkmale.

There are 48 entries in https://de.wikipedia.org/wiki/Liste_der_denkmalgesch%C3%BCtzten_Objekte_in_Reichenau_an_der_Rax, but only 37 are shown when filtering by just Denkmale. On the other hand, the Huthaus is shown by source WikiData and links to commonscat Huthaus, Glockenhaus am Knappenberg, Reichenau an der Rax.

Same for Pfarrkirche Edlach an der Rax, only shown via Wikidata linking to WP:de article in this case.

on the other hand Kath. Pfarrkirche hl. Barbara is shown with two data sources (Denkmalliste, Wikidata (linking to WP:de article)) - Filtering is done correctly, the object is shown only once when filtering for 'Weiteres', for 'Denkmale' or for both.

What is the difference? Between Huthaus and Pfarrkirche Edlach an der Rax (and not causing the different behaviour, as both behave the same):

What is the difference? Between Huthaus and Pfarrkirche hl. Barbara (which might be the cause, as they show different behaviour) ? their respective coords are identical in Denkmalliste & Wikidata

What is the difference? Between Pfarrkirche Edlach an der Rax and Pfarrkirche hl. Barbara (which might be the cause, as they show different behaviour) ? their respective coords are identical in Denkmalliste & Wikidata & their articles

any idea?

Don't know whether this is frontend or backend.

pixelhaufen commented 4 weeks ago

All should work now (parsing problem fixed) except Q2243233. There is no 'ObjektID' which is used as unique ID for the database for Denkmalliste. Can this be fixed in wp or is there another ID that can be used for Denkmalliste? (has to be present in all lists.. maybe WD-Item?)

HerziPinki commented 4 weeks ago

Yes, objects added after 2020 (which is the case for Q2243233) do not have an ObjectID. the ObjektID was replaced by HERIS-ID and as an id in our lists, by the WD-Item. So you are right, the key in the Denkmalliste is the WD-Item. So please use WD-Item as a key for Denkmalliste.

(we changed the anchor for table rows from ObjektID to WD-Item some years ago (last year?))

HerziPinki commented 3 weeks ago

the Huthaus in Reichenau is ok now

pixelhaufen commented 3 weeks ago

Fixed on a general level and in particular case. 48 in Reichenau an der Rax and WD-Item as new unique ID for Denkmalliste.