Wikunia / ConstraintSolver.jl

ConstraintSolver in Julia: Blog posts ->
https://opensourc.es/blog/constraint-solver-1
MIT License
135 stars 13 forks source link

Bugfix equal feasibility #152

Closed Wikunia closed 4 years ago

Wikunia commented 4 years ago

Check if other variables actually have the variable available

codecov[bot] commented 4 years ago

Codecov Report

Merging #152 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #152   +/-   ##
=======================================
  Coverage   98.91%   98.92%           
=======================================
  Files          31       31           
  Lines        2405     2409    +4     
=======================================
+ Hits         2379     2383    +4     
  Misses         26       26           
Flag Coverage Δ
#unittests 98.92% <100.00%> (+<0.01%) :arrow_up:
Impacted Files Coverage Δ
src/constraints/equal.jl 96.00% <100.00%> (+0.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1495427...2930eb6. Read the comment docs.

Wikunia commented 4 years ago

Benchmark Report for ConstraintSolver

Job Properties

Results

A ratio greater than 1.0 denotes a possible regression (marked with :x:), while a ratio less than 1.0 denotes a possible improvement (marked with :white_check_mark:). Only significant results - results that indicate possible regressions or improvements - are shown below (thus, an empty table means that all benchmark results remained invariant between builds).

ID time ratio memory ratio
["eternity", "5x5_all"] 0.67 (5%) :white_check_mark: 0.73 (1%) :white_check_mark:
["eternity", "6x5"] 0.88 (5%) :white_check_mark: 0.87 (1%) :white_check_mark:

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

Julia versioninfo

Target

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      "Arch Linux"
  uname: Linux 5.6.8-arch1-1 #1 SMP PREEMPT Wed, 29 Apr 2020 16:22:56 +0000 x86_64 unknown
  CPU: Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2800 MHz    1705684 s     386710 s     502826 s    7341399 s     111546 s
       #2  2800 MHz    1659515 s     389560 s     479352 s    2562665 s      25906 s
       #3  2800 MHz    1935466 s     280584 s     483787 s    2483858 s      25640 s
       #4  2800 MHz    1930098 s     259171 s     498683 s    2469197 s      38930 s

  Memory: 15.393684387207031 GB (8384.8671875 MB free)
  Uptime: 194001.0 sec
  Load Avg:  1.38623046875  1.30810546875  1.19140625
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)

Baseline

Julia Version 1.4.1
Commit 381693d3df* (2020-04-14 17:20 UTC)
Platform Info:
  OS: Linux (x86_64-pc-linux-gnu)
      "Arch Linux"
  uname: Linux 5.6.8-arch1-1 #1 SMP PREEMPT Wed, 29 Apr 2020 16:22:56 +0000 x86_64 unknown
  CPU: Intel(R) Core(TM) i7-7600U CPU @ 2.80GHz: 
              speed         user         nice          sys         idle          irq
       #1  2801 MHz    1712457 s     386710 s     503156 s    7362572 s     111655 s
       #2  2594 MHz    1662437 s     389560 s     479765 s    2587729 s      25928 s
       #3  2800 MHz    1955157 s     280584 s     484329 s    2492093 s      25676 s
       #4  2800 MHz    1931524 s     259171 s     499110 s    2495785 s      38947 s

  Memory: 15.393684387207031 GB (8286.1875 MB free)
  Uptime: 194286.0 sec
  Load Avg:  1.31640625  1.31787109375  1.21533203125
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-8.0.1 (ORCJIT, skylake)