Wikunia / ConstraintSolver.jl

ConstraintSolver in Julia: Blog posts ->
https://opensourc.es/blog/constraint-solver-1
MIT License
136 stars 14 forks source link

first version of reified #171

Closed Wikunia closed 4 years ago

Wikunia commented 4 years ago

Implements #165 needs treatment of #170

codecov[bot] commented 4 years ago

Codecov Report

Merging #171 into master will increase coverage by 0.01%. The diff coverage is 98.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
+ Coverage   98.77%   98.79%   +0.01%     
==========================================
  Files          32       34       +2     
  Lines        2619     2731     +112     
==========================================
+ Hits         2587     2698     +111     
- Misses         32       33       +1     
Flag Coverage Δ
#unittests 98.79% <98.29%> (+0.01%) :arrow_up:
Impacted Files Coverage Δ
src/hashes.jl 100.00% <ø> (ø)
src/MOI_wrapper/reified.jl 90.47% <90.47%> (ø)
src/ConstraintSolver.jl 99.15% <100.00%> (+<0.01%) :arrow_up:
src/MOI_wrapper/constraints.jl 100.00% <100.00%> (ø)
src/constraints/indicator.jl 100.00% <100.00%> (ø)
src/constraints/reified.jl 100.00% <100.00%> (ø)
src/types.jl 100.00% <100.00%> (ø)
src/util.jl 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e6d407c...2199c99. Read the comment docs.

Wikunia commented 4 years ago
Wikunia commented 4 years ago

Not sure yet whether anti prune is reasonable and seems like this would be needed for every constraint which seems like to much extra for this "special" case.

Wikunia commented 4 years ago

I think this can be used without anti prune first.

Wikunia commented 4 years ago

I think this can be merged when I had a look while writing a blog post :)